<html>
<head><meta charset="utf-8"><title>Improving Triage · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html">Improving Triage</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="222865726"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Improving%20Triage/near/222865726" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html#222865726">(Jan 15 2021 at 14:42)</a>:</h4>
<p>Regarding <span class="user-mention" data-user-id="116083">@pnkfelix</span>'s <a href="https://github.com/rust-lang/compiler-team/issues/400">meeting proposal for improving triage</a> I have several comments and questions:</p>
<ul>
<li>Can the classification of performance regression, improvement, mixed be more fine tuned? I believe we can use better heuristics for more accurately classifying. </li>
<li>Can we automate regression testing for rollups? It would be nice to have a @bors command that allows us to quickly quick off a revert of a given rollup PR coupled with a perf run</li>
<li>Related to the above, can we automate alerting PR authors and reviewers of performance regressions?</li>
<li>Should we pay less attention to improvements? Perhaps the noting of improvements generated by the report tool is enough and we shouldn't provide any more info on why an improvement was made. </li>
</ul>
<p>As I understand it, the purpose of the triage report is to keep the compiler team (and the wider community) informed about the progression of compiler performance. A consequence of this, is that we often alert compiler devs when something has regressed. I think the triage report is doing a poor job of its main purpose of informing but doing a decent job of ensuring regressions are looked into. </p>
<p>I think we should focus on improving the perf dashboard as a means of addressing the desire to track compiler perf and we should invest in some of the automation above to continue to ensure that devs are informed when their changes cause regressions. I'm not sure the compilation of a report (at least in its current form) is the right way to continue to track compiler performance.</p>



<a name="222868145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Improving%20Triage/near/222868145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html#222868145">(Jan 15 2021 at 14:59)</a>:</h4>
<p>heh, we actually have the automated regression testing, I should teach you it</p>



<a name="222868296"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Improving%20Triage/near/222868296" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html#222868296">(Jan 15 2021 at 15:00)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/247081-t-compiler.2Fperformance/topic/Improving.20Triage/near/222868145">said</a>:</p>
<blockquote>
<p>heh, we actually have the automated regression testing, I should teach you it</p>
</blockquote>
<p>🤯</p>



<a name="222868333"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Improving%20Triage/near/222868333" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html#222868333">(Jan 15 2021 at 15:00)</a>:</h4>
<p>overall though I agree with your points, would be great to invest time here, I'm really busy</p>



<a name="222868503"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Improving%20Triage/near/222868503" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html#222868503">(Jan 15 2021 at 15:01)</a>:</h4>
<p><a href="https://github.com/rust-lang/rustc-perf/pull/701">https://github.com/rust-lang/rustc-perf/pull/701</a></p>



<a name="222868798"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Improving%20Triage/near/222868798" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html#222868798">(Jan 15 2021 at 15:02)</a>:</h4>
<p>I forget if there was an unfixed bug in that and I forget what that bug precisely was, but I think it should work</p>



<a name="222882213"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Improving%20Triage/near/222882213" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> The 8472 <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Improving.20Triage.html#222882213">(Jan 15 2021 at 16:22)</a>:</h4>
<p>I think for the community it would be nice to have summaries improvements across a longer timeframe. njn's blog posts used to serve that purpose.</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>